Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore installability of package #983

Merged
merged 5 commits into from
Aug 12, 2024

Conversation

spiess-demos
Copy link
Contributor

@spiess-demos spiess-demos commented Aug 8, 2024

Due to several things, the yarn.lock and package.json were out of sync, so that vue-loader was not installed anymore by yarn 1 and the build failed consequently.

This change restores the state of the package.json before bumping Yarn to 4, and it additionally removes "@webpack-cli/generators" which seems to be a remnant of bootstrapping the project build.

Also, this change bumps several dependencies to their latest resolvable minor versions as i deleted yarn.lock before running yarn install to have a clean start, again.

Also, this change defines resolutions for string-width and wrap-ansi to fix the string-width-error, again. See this comment for an explanation.

Due to several things, the yarn.lock and package.json
were out of sync, so that vue-loader was not installed
anymore by yarn 1 and the build failed consequently.

This change restores the state of the package.json
before bumping Yarn to 4, and it additionally removes
"@webpack-cli/generators" which seems to be a remnant of
bootstrapping the project build.

Also, this change bumps several dependencies to their latest
resolvable minor versions as i deleted yarn.lock before
running `yarn install` to have a clean start, again.
@spiess-demos spiess-demos requested review from mussbach and hwiem August 8, 2024 14:32
Copy link
Contributor

@hwiem hwiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I run yarn build (after running yarn), I get the string-width error and need to run yarn upgrade jest to make it work. This results in an updated yarn.lock. Should that be commited?

@spiess-demos
Copy link
Contributor Author

When I run yarn build (after running yarn), I get the string-width error and need to run yarn upgrade jest to make it work. This results in an updated yarn.lock. Should that be commited?

i got the string-width error, too. but sadly, after running yarn upgrade jest i got no changes in yarn.lock. idk how to deal with that. maybe you could commit your changes?

Copy link
Contributor

@hwiem hwiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm + works, thanks ❤️

@spiess-demos spiess-demos merged commit 86de146 into main Aug 12, 2024
1 check passed
@spiess-demos spiess-demos deleted the f_restore-installability-of-demosplan-ui branch August 12, 2024 09:15
salisdemos pushed a commit that referenced this pull request Dec 10, 2024
Due to several things, the yarn.lock and package.json
were out of sync, so that vue-loader was not installed
anymore by yarn 1 and the build failed consequently.

This change restores the state of the package.json
before bumping Yarn to 4, and it additionally removes
"@webpack-cli/generators" which seems to be a remnant of
bootstrapping the project build.

Also, this change bumps several dependencies to their latest
resolvable minor versions as i deleted yarn.lock before
running `yarn install` to have a clean start, again.

Lastly, this change fixes string-width and wrap-ansi at specific
resolutions, to overcome the "string-width-error" once more.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants